dsisnero opened a new pull request, #39551:
URL: https://github.com/apache/arrow/pull/39551

   fix error in code.  Also, this doesn't work for me on windows.
   
   When I run this code, I get the following:
   
   ```
   e:\programming\source\repos\ruby\try_arrow>gem install red-gandiva 
Temporarily enhancing PATH for MSYS/MINGW...
   Building native extensions. This could take a while... Successfully 
installed red-gandiva-14.0.2
   Building YARD (yri) index for red-gandiva-14.0.2... Done installing 
documentation for red-gandiva after 0 seconds 1 gem installed
   
   e:\programming\source\repos\ruby\try_arrow>ruby arrow_gandiva_test.rb 
(NULL)-WARNING **: Failed to load shared library 'libgandiva-glib-1400.dll' 
referenced by the typelib: 'libgandiva-glib-1400.dll': The specified module 
could not be found.
           from 
E:/windows/tools/ruby/Ruby33-x64/lib/ruby/gems/3.3.0/gems/gobject-introspection-4.2.0/lib/gobject-introspection/loader.rb:243:in
 `load_object_info'
           from 
E:/windows/tools/ruby/Ruby33-x64/lib/ruby/gems/3.3.0/gems/gobject-introspection-4.2.0/lib/gobject-introspection/loader.rb:73:in
 `load_info'
           from 
E:/windows/tools/ruby/Ruby33-x64/lib/ruby/gems/3.3.0/gems/gobject-introspection-4.2.0/lib/gobject-introspection/loader.rb:47:in
 `block (2 levels) in load'
           from 
E:/windows/tools/ruby/Ruby33-x64/lib/ruby/gems/3.3.0/gems/gobject-introspection-4.2.0/lib/gobject-introspection/repository.rb:34:in
 `block (2 levels) in each'
           from <internal:numeric>:237:in `times'
           from 
E:/windows/tools/ruby/Ruby33-x64/lib/ruby/gems/3.3.0/gems/gobject-introspection-4.2.0/lib/gobject-introspection/repository.rb:33:in
 `block in each'
           from 
E:/windows/tools/ruby/Ruby33-x64/lib/ruby/gems/3.3.0/gems/gobject-introspection-4.2.0/lib/gobject-introspection/repository.rb:32:in
 `each'
           from 
E:/windows/tools/ruby/Ruby33-x64/lib/ruby/gems/3.3.0/gems/gobject-introspection-4.2.0/lib/gobject-introspection/repository.rb:32:in
 `each'
           from 
E:/windows/tools/ruby/Ruby33-x64/lib/ruby/gems/3.3.0/gems/gobject-introspection-4.2.0/lib/gobject-introspection/loader.rb:46:in
 `block in load'
           from 
E:/windows/tools/ruby/Ruby33-x64/lib/ruby/gems/3.3.0/gems/gobject-introspection-4.2.0/lib/gobject-introspection/loader.rb:636:in
 `prepare_class'
           from 
E:/windows/tools/ruby/Ruby33-x64/lib/ruby/gems/3.3.0/gems/gobject-introspection-4.2.0/lib/gobject-introspection/loader.rb:41:in
 `load'
           from 
E:/windows/tools/ruby/Ruby33-x64/lib/ruby/gems/3.3.0/gems/gobject-introspection-4.2.0/lib/gobject-introspection/loader.rb:25:in
 `load'
           from 
E:/windows/tools/ruby/Ruby33-x64/lib/ruby/gems/3.3.0/gems/red-gandiva-14.0.2/lib/gandiva/loader.rb:22:in
 `load'
           from 
E:/windows/tools/ruby/Ruby33-x64/lib/ruby/gems/3.3.0/gems/red-gandiva-14.0.2/lib/gandiva.rb:28:in
 `<module:Gandiva>'
           from 
E:/windows/tools/ruby/Ruby33-x64/lib/ruby/gems/3.3.0/gems/red-gandiva-14.0.2/lib/gandiva.rb:24:in
 `<top (required)>'
           from 
<internal:E:/windows/tools/ruby/Ruby33-x64/lib/ruby/site_ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:132:in
 `require'
           from 
<internal:E:/windows/tools/ruby/Ruby33-x64/lib/ruby/site_ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:132:in
 `rescue in require'
           from 
<internal:E:/windows/tools/ruby/Ruby33-x64/lib/ruby/site_ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:126:in
 `require'
           from arrow_gandiva_test.rb:1:in `<main>'
   
E:/windows/tools/ruby/Ruby33-x64/lib/ruby/gems/3.3.0/gems/red-gandiva-14.0.2/lib/gandiva/expression-builder/field.rb:28:in
 `build': uninitialized constant Gandiva::ExpressionBuilder::Field::FieldNode 
(NameError)
   
           FieldNode.new(@field)
           ^^^^^^^^^
           from 
E:/windows/tools/ruby/Ruby33-x64/lib/ruby/gems/3.3.0/gems/red-gandiva-14.0.2/lib/gandiva/expression-builder/binary-operation.rb:30:in
 `build'
           from 
E:/windows/tools/ruby/Ruby33-x64/lib/ruby/gems/3.3.0/gems/red-gandiva-14.0.2/lib/gandiva/expression-builder.rb:26:in
 `build'
           from 
E:/windows/tools/ruby/Ruby33-x64/lib/ruby/gems/3.3.0/gems/red-gandiva-14.0.2/lib/gandiva/arrow-schema.rb:22:in
 `build_expression'
           from arrow_gandiva_test.rb:7:in `<main>'
   ```
   
   
   <!--
   Thanks for opening a pull request!
   If this is your first pull request you can find detailed information on how 
   to contribute here:
     * [New Contributor's 
Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
     * [Contributing 
Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
   
   
   If this is not a [minor 
PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). 
Could you open an issue for this pull request on GitHub? 
https://github.com/apache/arrow/issues/new/choose
   
   Opening GitHub issues ahead of time contributes to the 
[Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.)
 of the Apache Arrow project.
   
   Then could you also rename the pull request title in the following format?
   
       GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   In the case of PARQUET issues on JIRA the title also supports:
   
       PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
   
   -->
   
   ### Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in 
the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your 
changes and offer better suggestions for fixes.  
   -->
   
   ### What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is 
sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   ### Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are 
they covered by existing tests)?
   -->
   
   ### Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be 
updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please uncomment the line 
below and explain which changes are breaking.
   -->
   <!-- **This PR includes breaking changes to public APIs.** -->
   
   <!--
   Please uncomment the line below (and provide explanation) if the changes fix 
either (a) a security vulnerability, (b) a bug that caused incorrect or invalid 
data to be produced, or (c) a bug that causes a crash (even when the API 
contract is upheld). We use this to highlight fixes to issues that may affect 
users without their knowledge. For this reason, fixing bugs that cause errors 
don't count, since those are usually obvious.
   -->
   <!-- **This PR contains a "Critical Fix".** -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to