viirya commented on code in PR #8823:
URL: https://github.com/apache/arrow-datafusion/pull/8823#discussion_r1449422452
##########
datafusion/physical-expr/src/planner.rs:
##########
@@ -43,29 +43,17 @@ use std::sync::Arc;
/// * `e` - The logical expression
/// * `input_dfschema` - The DataFusion schema for the input, used to resolve
`Column` references
/// to qualified or unqualified fields by name.
-/// * `input_schema` - The Arrow schema for the input, used for determining
expression data types
-/// when performing type coercion.
pub fn create_physical_expr(
e: &Expr,
input_dfschema: &DFSchema,
- input_schema: &Schema,
Review Comment:
Then it is weird to have duplicate parameters. I guess it might has some
reason (i.e., rare cases they might be different).
@liukun4515 Do you remember it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
