assignUser commented on code in PR #39524:
URL: https://github.com/apache/arrow/pull/39524#discussion_r1449727336
##########
r/tools/nixlibs.R:
##########
@@ -860,7 +860,8 @@ if (is_release) {
VERSION <- VERSION[1, 1:3]
arrow_repo <- paste0(getOption("arrow.repo",
sprintf("https://apache.jfrog.io/artifactory/arrow/r/%s";, VERSION)),
"/libarrow/")
} else {
- not_cran <- TRUE
+ # Don't override explictily set NOT_CRAN env var, as it is used in CI.
+ not_cran <- TRUE && !env_is("NOT_CRAN", "false")
Review Comment:
No, this is intentional. We only want to default to setting `not_cran <-
TRUE` if we are on a dev version. For release versions people have to
explicitly opt in, this is needed for CRAN (as the name implies^^).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
