zanmato1984 commented on issue #32570: URL: https://github.com/apache/arrow/issues/32570#issuecomment-1889644728
> Another thing I want to mention is that, I only fixed the non-fixed-length case, because I think all fixed-length cases will be fine (disclaimer: I could be wrong) based on the following facts: > > 1. All fixed-lengths <= 8-byte use direct copy so don't need to skip any rows: https://github.com/apache/arrow/blob/4e58f7ca0016c2b2d8a859a0c5965df3b15523e0/cpp/src/arrow/compute/light_array.cc#L508-L543 > 2. The rest fixed-lengths (> 8-byte) do skip rows https://github.com/apache/arrow/blob/4e58f7ca0016c2b2d8a859a0c5965df3b15523e0/cpp/src/arrow/compute/light_array.cc#L547 > . But they'll be fine because they'd be multiple of 8-byte. Update: these analysis of fixed size types are wrong. See #39583 and the subsequent fix #39585 for details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
