eddelbuettel opened a new issue, #362:
URL: https://github.com/apache/arrow-nanoarrow/issues/362
After syncing with the headers as in `dist/` now (and from a very gentle and
gingerly use of a little JSON as now supported) I started to see this in a
little test repo:
```
nanoarrow/nanoarrow_testing.hpp: In member function ‘ArrowErrorCode
nanoarrow::testing::TestingJSONWriter::WriteColumn(std::ostream&, const
ArrowSchema*, const ArrowArrayView*)’:
nanoarrow/nanoarrow_testing.hpp:470:42: warning: moving a temporary object
prevents copy elision [-Wpessimizing-move]
470 | std::move(dictionary_output.str()));
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
nanoarrow/nanoarrow_testing.hpp:470:42: note: remove ‘std::move’ call
```
and indeed, just removing the `std::move()` appears to work in the 'well
`valgrind` does not complain' sense.
So I can send you a PR that does the equivalent of this if you want me to.
I am on Ubuntu 23.10 with `g++-13` version 13.2.0 in case it matters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
