pacman82 commented on issue #5177: URL: https://github.com/apache/arrow-rs/issues/5177#issuecomment-1890415386
> If it makes you feel any better, this would likely be subtly incorrect for data with repetition levels 😄 Only had flat, table like data, so I might have been lucky in the past. > I would be interested in any numbers where this represents a regression, mainly because https://github.com/apache/arrow-rs/pull/5193 represented a non-trivial performance uplift in many cases. I'd be willing to consider alternative suggestions to fixing https://github.com/apache/arrow-rs/issues/5150 if this represents a major regression for your workloads. I have little reason to doubt you. Some tests are still failing, but I will just update. I would not have the time to set a benchmark up. Even if I would, there are so many variables (type of column, number of rows etc.) that its outcome unless mindbogglingly significant would not allow any conclusions. Nice to hear that you had some nice speedups though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
