paleolimbot commented on issue #364: URL: https://github.com/apache/arrow-nanoarrow/issues/364#issuecomment-1890656535
I definitely would have expected that either of those options would result in a shared nanoarrow; however, I'm not an expert in CMake and it's come up recently that our CMake config is not all that helpful for some other patterns as well (#352). I'm also not an expert in skbuild/Python builds in general...I expected most people to just include `nanoarrow.c` in the sources for `add_library()`, but it looks like nanobind has its own thing for that and maybe you can't just add another .c source file there. I think you might also want to set NANOARROW_NAMESPACE as well (to make sure that your package's nanoarrow doesn't collide with another version of nanoarrow in another package). We definitely need to do a better job documenting/testing the various configuration in which we expect nanoarrow to be actually used 🙂 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
