kou commented on issue #39590: URL: https://github.com/apache/arrow/issues/39590#issuecomment-1890771386
In general, we should do this. For the Thrift and Boost case, we should pass Boost related parameters based on found Thrift instead of passed parameters by a user. https://github.com/apache/arrow/blob/87ed8ac432dc7e77fa0275a24e3edda9b0bc2a2e/cpp/cmake_modules/ThirdpartyToolchain.cmake#L1653-L1658 uses `BOOST_ROOT` and `Boost_NAMESPACE` but we should use values detected from `Boost::*` targets. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
