kou commented on code in PR #1462:
URL: https://github.com/apache/arrow-adbc/pull/1462#discussion_r1451681927
##########
c/driver/postgresql/copy/writer.h:
##########
@@ -477,7 +474,7 @@ class PostgresCopyTimestampFieldWriter : public
PostgresCopyFieldWriter {
return ADBC_STATUS_INVALID_ARGUMENT;
}
- if (value < std::numeric_limits<int64_t>::min() + kPostgresTimestampEpoch)
{
+ if (value < (std::numeric_limits<int64_t>::min)() +
kPostgresTimestampEpoch) {
Review Comment:
This is for avoiding name conflict on Windows.
`windef.h` defines `min` macro. It conflicts with
`std::numeric_limits::min()`. If we use `(std::numeric_limits::min)()`, we can
avoid the `min` macro expansion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
