alamb commented on PR #8847:
URL: 
https://github.com/apache/arrow-datafusion/pull/8847#issuecomment-1890945954

   > The problem may not related to ci, because I tested it on cli, and it also 
worked. @alamb
   
   Right, sorry, what I was saying is that given there is a bug you found in 
the code (by manual inspection) but 
   1. it wasn't found by tests
   2. you didn't have to update any tests when you changed the code
   
   I conclude there is a gap in our test coverage. Thus I was suggesting we 
find a way to write a test that would fail prior to this code change, but will 
pass with the change


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to