korowa commented on PR #8020:
URL:
https://github.com/apache/arrow-datafusion/pull/8020#issuecomment-1891004832
cc @alamb @metesynnada
I suppose this version to be ready for review. Could you, please, take a
look when you have some time?
Just in case -- tpch_mem results for this version are
```
--------------------
Benchmark tpch_mem.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Query ┃ master ┃ hash_join_batch_size ┃ Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩
│ QQuery 1 │ 219.32ms │ 222.32ms │ no change │
│ QQuery 2 │ 41.97ms │ 42.19ms │ no change │
│ QQuery 3 │ 98.34ms │ 96.49ms │ no change │
│ QQuery 4 │ 91.24ms │ 93.54ms │ no change │
│ QQuery 5 │ 158.88ms │ 159.20ms │ no change │
│ QQuery 6 │ 25.88ms │ 26.33ms │ no change │
│ QQuery 7 │ 349.07ms │ 373.73ms │ 1.07x slower │
│ QQuery 8 │ 69.36ms │ 72.65ms │ no change │
│ QQuery 9 │ 158.26ms │ 159.75ms │ no change │
│ QQuery 10 │ 160.81ms │ 164.02ms │ no change │
│ QQuery 11 │ 48.31ms │ 47.87ms │ no change │
│ QQuery 12 │ 73.05ms │ 72.87ms │ no change │
│ QQuery 13 │ 113.89ms │ 118.59ms │ no change │
│ QQuery 14 │ 27.29ms │ 30.08ms │ 1.10x slower │
│ QQuery 15 │ 45.36ms │ 46.13ms │ no change │
│ QQuery 16 │ 55.31ms │ 55.95ms │ no change │
│ QQuery 17 │ 156.56ms │ 162.25ms │ no change │
│ QQuery 18 │ 476.42ms │ 527.85ms │ 1.11x slower │
│ QQuery 19 │ 64.40ms │ 69.18ms │ 1.07x slower │
│ QQuery 20 │ 122.47ms │ 127.80ms │ no change │
│ QQuery 21 │ 346.16ms │ 361.06ms │ no change │
│ QQuery 22 │ 42.12ms │ 43.32ms │ no change │
└──────────────┴──────────┴──────────────────────┴──────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (master) │ 2944.46ms │
│ Total Time (hash_join_batch_size) │ 3073.18ms │
│ Average Time (master) │ 133.84ms │
│ Average Time (hash_join_batch_size) │ 139.69ms │
│ Queries Faster │ 0 │
│ Queries Slower │ 4 │
│ Queries with No Change │ 18 │
└─────────────────────────────────────┴───────────┘
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
