andygrove commented on PR #8835: URL: https://github.com/apache/arrow-datafusion/pull/8835#issuecomment-1891008411
The `Transformed` enum was introduced in https://github.com/apache/arrow-datafusion/pull/5630 There is a comment `Introduce enum Transformed to avoid clone in the TreeNode` but I am not sure that this is still relevant. This PR does not seem to be adding any additional clones. It does seem useful to know if a rule transformed the plan or not without having to perform an expensive plan comparison. This functionality does not seem to be used within DataFusion though. I wonder if downstream projects are making use of this public API? I'd also like to see if we can an opinion from @yahoNanJing or @liukun4515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
