jonkeane commented on code in PR #39587:
URL: https://github.com/apache/arrow/pull/39587#discussion_r1451771273
##########
r/tools/nixlibs.R:
##########
@@ -116,33 +105,56 @@ download_binary <- function(lib) {
# validate binary checksum for CRAN release only
if (!skip_checksum && dir.exists(checksum_path) && is_release ||
enforce_checksum) {
Review Comment:
With this logic now we will skip the checksum (in this case, get to this
function and then reply with `checksum_ok == TRUE` if any of these are true:
* the skip var is set
* it's not a release
* the directory `tools/checksums` does not exist
Is that last one right? I get that we're trying to be protective here, and
if there's no checksum file we will fail the checksum. But do we want to have
this particular escape hatch here rather than failing the checksum (and then
presumably building from source)?
Thoughts @assignUser ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
