avantgardnerio commented on issue #8860:
URL: 
https://github.com/apache/arrow-datafusion/issues/8860#issuecomment-1891039888

   > > Hi @alamb , do you know why these are failing to use the code in my PRs? 
I think there are a number of cases that they could be extended to cover, 
without an extreme amount of effort.
   > 
   > If you mean "why isn't the code added in #7192 used in the ClickBench 
queries" I think it is because none of the 
[`queries`](https://github.com/apache/arrow-datafusion/blob/main/benchmarks/queries/clickbench/queries.sql)
 has the pattern that PR handles, e.g.
   > 
   > ```sql
   > SELECT min(time), group_id FROM ... GROUP BY group_id ORDER BY min(time) 
LIMIT ...
   > ```
   
   ah, okay. I was hoping some queries were similar enough to be accelerated by 
that code, given a little effort, but it does not appear that way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to