devinjdangelo commented on code in PR #8854:
URL: https://github.com/apache/arrow-datafusion/pull/8854#discussion_r1451842351
##########
datafusion/common/src/config.rs:
##########
@@ -403,7 +403,7 @@ config_namespace! {
/// parquet files by serializing them in parallel. Each column
/// in each row group in each output file are serialized in parallel
/// leveraging a maximum possible core count of
n_files*n_row_groups*n_columns.
- pub allow_single_file_parallelism: bool, default = true
+ pub allow_single_file_parallelism: bool, default = false
Review Comment:
As flagged in #8851 and #8853, setting this to true will result in the new
copy.slt tests to fail.
##########
datafusion/sqllogictest/test_files/copy.slt:
##########
@@ -64,6 +64,25 @@ select * from validate_parquet;
1 Foo
2 Bar
+query ??
+COPY
+(values (struct ('foo', (struct ('foo', make_array(1,2,3)))),
make_array(timestamp '2023-01-01 01:00:01',timestamp '2023-01-01 01:00:01')),
Review Comment:
New test case covers:
1. Struct types
2. Array types
3. Multiple levels of nesting (struct of struct with array value)
4. Timestamp types
I attempted to add array of struct as specifically flagged in #8851, but was
unable to construct the literal value due to #8867.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
