raulcd commented on code in PR #39605:
URL: https://github.com/apache/arrow/pull/39605#discussion_r1452184768
##########
dev/release/verify-release-candidate.sh:
##########
@@ -880,8 +880,8 @@ test_csharp() {
if [ "${SOURCE_KIND}" = "local" ]; then
echo "Skipping sourelink verification on local build"
else
- dotnet tool run sourcelink test
artifacts/Apache.Arrow/Release/netstandard1.3/Apache.Arrow.pdb
- dotnet tool run sourcelink test
artifacts/Apache.Arrow/Release/netcoreapp3.1/Apache.Arrow.pdb
+ dotnet tool run sourcelink test
artifacts/Apache.Arrow/Release/netstandard2.0/Apache.Arrow.pdb
Review Comment:
I have no experience with C# and I might be saying something that doesn't
make sense but is there a reason why we don't test this when `SOURCE_KIND` is
`local`?
We probably could find the issue on nightlies / maintenance branch if we
also tested there instead of only when we have generated a Release candidate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
