alamb commented on code in PR #8868:
URL: https://github.com/apache/arrow-datafusion/pull/8868#discussion_r1452258989
##########
datafusion/proto/Cargo.toml:
##########
@@ -51,6 +51,7 @@ pbjson = { version = "0.6.0", optional = true }
prost = "0.12.0"
serde = { version = "1.0", optional = true }
serde_json = { workspace = true, optional = true }
+strum = { version = "0.25.0", features = ["derive"] }
Review Comment:
BTW since this module is only used in the tests, we should put it in the
`dev-dependencies` section, so everyone using `datafusion-proto` does not need
to compile it as well
I did this in 0a41737b1
##########
datafusion/proto/src/logical_plan/from_proto.rs:
##########
@@ -1588,7 +1588,7 @@ pub fn parse_expr(
Ok(character_length(parse_expr(&args[0], registry)?))
}
ScalarFunction::Chr => Ok(chr(parse_expr(&args[0],
registry)?)),
- ScalarFunction::InitCap => Ok(ascii(parse_expr(&args[0],
registry)?)),
+ ScalarFunction::InitCap => Ok(initcap(parse_expr(&args[0],
registry)?)),
Review Comment:
💯 for testing @Weijun-H -- your test also found two other functions with
similar problems to https://github.com/apache/arrow-datafusion/pull/8847 👏
I took the liberty of fixing them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
