tustvold commented on issue #5303: URL: https://github.com/apache/arrow-rs/issues/5303#issuecomment-1892515580
A few points: * The current logic is quite highly optimised, we need to be careful not to introduce any performance regressions * There are a couple of known bugs with the chrono format strings where the parser is overly permissive - https://github.com/chronotope/chrono/issues/332 * Timestamp parsing, especially timezones is very fiddly. I would request we keep code changes small, as it is very easy to subtly break things Overall I am rather lukewarm on this functionality, but I will endeavour to review well tested and focused changes to this logic -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
