nealrichardson commented on code in PR #39625:
URL: https://github.com/apache/arrow/pull/39625#discussion_r1452829941
##########
ci/scripts/r_docker_configure.sh:
##########
@@ -91,8 +91,9 @@ if [ -f
"${ARROW_SOURCE_HOME}/ci/scripts/r_install_system_dependencies.sh" ]; th
"${ARROW_SOURCE_HOME}/ci/scripts/r_install_system_dependencies.sh"
fi
-# Install rsync for bundling cpp source and curl to make sure it is installed
on all images
-$PACKAGE_MANAGER install -y rsync curl
+# Install rsync for bundling cpp source and curl to make sure it is installed
on all images,
+# cmake is now a listed sys req.
+$PACKAGE_MANAGER install -y rsync cmake curl
Review Comment:
If `cmake` isn't new enough on the `test-r-offline-maximal` job, it will
still fail. 🤞 this is fine, otherwise we'll want to use install_cmake.sh
##########
docker-compose.yml:
##########
@@ -1413,7 +1413,7 @@ services:
<<: *common
ARROW_DEPENDENCY_SOURCE: ''
ARROW_SOURCE_HOME: '/arrow'
- FORCE_BUNDLED_BUILD: 'true'
Review Comment:
Unless you're going to do all of the things in #39620, `FORCE_BUNDLED_BUILD`
is still how you skip looking for libarrow with pkg-config. This may be fine
here, I'm not sure how `extends: ubuntu-r` works in docker-compose, if this
overrides the `ubuntu-r` `command:`, then libarrow won't be built on the system
already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
