SteveLauC opened a new pull request, #8883:
URL: https://github.com/apache/arrow-datafusion/pull/8883

   ## Which issue does this PR close?
   
   Can be seen as a fix to #2990.
   
   ## Rationale for this change
   
   The `FileStream.file_reader` field is a generic type that implements the 
`FileOpener` trait, so it is kinda confusing to call it `file_reader` rather 
than `file_opener`.
   
   #2291 tried to do some naming refactoring to this file, but it seems that 
@tustvold forgot to update this field name I guess?
   
   And that doc comment was added in #1138, which is quite old and outdated.
   
   ## What changes are included in this PR?
   
   1. rename `FileStream.file_reader` to `FileStream.file_opener`.
   2. Update the doc for this field.
   
   ## Are these changes tested?
   
   No
   
   ## Are there any user-facing changes?
   
   This field is private so I guess no.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to