mapleFU commented on code in PR #39632:
URL: https://github.com/apache/arrow/pull/39632#discussion_r1453379429
##########
cpp/src/arrow/dataset/file_parquet.cc:
##########
@@ -813,11 +813,17 @@ Status
ParquetFileFragment::EnsureCompleteMetadata(parquet::arrow::FileReader* r
Status ParquetFileFragment::SetMetadata(
std::shared_ptr<parquet::FileMetaData> metadata,
- std::shared_ptr<parquet::arrow::SchemaManifest> manifest) {
+ std::shared_ptr<parquet::arrow::SchemaManifest> manifest,
+ std::shared_ptr<parquet::FileMetaData> original_metadata) {
DCHECK(row_groups_.has_value());
metadata_ = std::move(metadata);
manifest_ = std::move(manifest);
+ original_metadata_ = original_metadata ? std::move(original_metadata) :
metadata_;
Review Comment:
Yeah, I misunderstand this previously, `metadata_` is from Subset, but
`manifest` is shared and having lifetime problem here.
##########
cpp/src/arrow/dataset/file_parquet.cc:
##########
@@ -813,11 +813,17 @@ Status
ParquetFileFragment::EnsureCompleteMetadata(parquet::arrow::FileReader* r
Status ParquetFileFragment::SetMetadata(
std::shared_ptr<parquet::FileMetaData> metadata,
- std::shared_ptr<parquet::arrow::SchemaManifest> manifest) {
+ std::shared_ptr<parquet::arrow::SchemaManifest> manifest,
+ std::shared_ptr<parquet::FileMetaData> original_metadata) {
DCHECK(row_groups_.has_value());
metadata_ = std::move(metadata);
manifest_ = std::move(manifest);
+ original_metadata_ = original_metadata ? std::move(original_metadata) :
metadata_;
Review Comment:
Yeah, I misunderstand this previously, `metadata_` is from Subset, but
`manifest` is shared and having lifetime problem here, this looks ok to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
