AlenkaF commented on PR #39609:
URL: https://github.com/apache/arrow/pull/39609#issuecomment-1893736540
I think this PR looks good now.
The only missing thing I have to solve is this warning about comparison with
empty arrays (coming from `pandas.testing.assert_frame_equal`):
```
=============================== warnings summary
===============================
opt/conda/envs/arrow/lib/python3.10/site-packages/pyarrow/tests/test_pandas.py::TestConvertMetadata::test_empty_list_metadata
opt/conda/envs/arrow/lib/python3.10/site-packages/pyarrow/tests/test_pandas.py::TestConvertListTypes::test_empty_list_roundtrip
/opt/conda/envs/arrow/lib/python3.10/site-packages/pandas/core/dtypes/missing.py:578:
DeprecationWarning: The truth value of an empty array is ambiguous. Returning
False, but in future this will result in an error. Use `array.size > 0` to
check that an array is not empty.
return lib.array_equivalent_object(left, right)
opt/conda/envs/arrow/lib/python3.10/site-packages/pyarrow/tests/test_pandas.py:
2 warnings
opt/conda/envs/arrow/lib/python3.10/site-packages/pyarrow/tests/parquet/test_data_types.py:
3 warnings
opt/conda/envs/arrow/lib/python3.10/site-packages/pyarrow/tests/parquet/test_pandas.py:
2 warnings
opt/conda/envs/arrow/lib/python3.10/site-packages/pyarrow/tests/parquet/test_parquet_file.py:
6 warnings
/opt/conda/envs/arrow/lib/python3.10/site-packages/pandas/core/dtypes/missing.py:579:
DeprecationWarning: The truth value of an empty array is ambiguous. Returning
False, but in future this will result in an error. Use `array.size > 0` to
check that an array is not empty.
if not lib.array_equivalent_object(left[~mask], right[~mask]):
```
But I would do this in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
