nealrichardson commented on code in PR #39627: URL: https://github.com/apache/arrow/pull/39627#discussion_r1453451309
########## r/NEWS.md: ########## @@ -19,6 +19,17 @@ # arrow 14.0.2.9000 +## Minor improvements and fixes Review Comment: Seems like we should note the build changes we just merged under minor improvements ########## r/NEWS.md: ########## @@ -19,6 +19,17 @@ # arrow 14.0.2.9000 +## Minor improvements and fixes + +* Throw error when `string_replace` is passed vector of values in `pattern` (#39219) Review Comment: ``` > stringr::string_replace Error: 'string_replace' is not an exported object from 'namespace:stringr' ``` Isn't is `str_replace_all()`? ########## r/NEWS.md: ########## @@ -19,6 +19,17 @@ # arrow 14.0.2.9000 +## Minor improvements and fixes + +* Throw error when `string_replace` is passed vector of values in `pattern` (#39219) +* Document `open_dataset(format = "json")` (#38258) + +## New features Review Comment: Shouldn't New features go before Minor improvements and fixes? ########## r/NEWS.md: ########## @@ -19,6 +19,17 @@ # arrow 14.0.2.9000 +## Minor improvements and fixes + +* Throw error when `string_replace` is passed vector of values in `pattern` (#39219) +* Document `open_dataset(format = "json")` (#38258) + +## New features + +* Add `prod`-binding for `summarize()` (#38601) Review Comment: As someone who hasn't been involved day-to-day in development, I have no idea what this means. Could this be revised for clarity? ########## r/NEWS.md: ########## @@ -19,6 +19,17 @@ # arrow 14.0.2.9000 +## Minor improvements and fixes + +* Throw error when `string_replace` is passed vector of values in `pattern` (#39219) Review Comment: ``` > stringr::string_replace Error: 'string_replace' is not an exported object from 'namespace:stringr' ``` Isn't it `str_replace_all()`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
