sgilmore10 commented on code in PR #38660: URL: https://github.com/apache/arrow/pull/38660#discussion_r1453961078
########## matlab/tools/packageMatlabInterface.m: ########## @@ -0,0 +1,58 @@ +% Licensed to the Apache Software Foundation (ASF) under one +% or more contributor license agreements. See the NOTICE file +% distributed with this work for additional information +% regarding copyright ownership. The ASF licenses this file +% to you under the Apache License, Version 2.0 (the +% "License"); you may not use this file except in compliance +% with the License. You may obtain a copy of the License at +% +% http://www.apache.org/licenses/LICENSE-2.0 +% +% Unless required by applicable law or agreed to in writing, +% software distributed under the License is distributed on an +% "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +% KIND, either express or implied. See the License for the +% specific language governing permissions and limitations +% under the License. + +toolboxFolder = string(getenv("ARROW_MATLAB_TOOLBOX_FOLDER")); +outputFolder = string(getenv("ARROW_MATLAB_TOOLBOX_OUTPUT_FOLDER")); +toolboxVersionRaw = string(getenv("ARROW_MATLAB_TOOLBOX_VERSION")); + +% Output folder must exist. +mkdir(outputFolder); + +disp("Toolbox Folder: " + toolboxFolder); +disp("Output Folder: " + outputFolder); +disp("Toolbox Version Raw: " + toolboxVersionRaw); + +% Note: This string processing heuristic may not be robust to future +% changes in the Arrow versioning scheme. +dotIdx = strfind(toolboxVersionRaw, "."); +numDots = numel(dotIdx); +if numDots >= 3 + toolboxVersion = extractBefore(toolboxVersionRaw, dotIdx(3)); +else + toolboxVersion = toolboxVersionRaw; +end + +disp("Toolbox Version:" + toolboxVersion); + +identifier = "ad1d0fe6-22d1-4969-9e6f-0ab5d0f12ce3"; +opts = matlab.addons.toolbox.ToolboxOptions(toolboxFolder, identifier); Review Comment: Hi Everyone, Thanks very much for patiently waiting on us to move this forward. We realized that we need to ensure that the licenses of any MEX artifacts bundled with the released MLTBX file must be compatible with the ASF 3rd Party License Policy. After several rounds of discussion with some colleagues at MathWorks (unfortunately delayed due to the holiday season in the US), we came up with a license ([attached to this comment](https://github.com/apache/arrow/files/13955180/license.txt)) that we hope will allow us to ensure that we are abiding by the ASF's 3rd Party License Policy. The attached license is a modified version of the standard MathWorks license that applies to MEX files. The intent of these modifications is to meet the requirements for inclusion as a ["Category B"](https://www.apache.org/legal/resolved.html#category-b) license according to the ASF 3rd Party License Policy. Our goal is to make sure we are doing the right thing here, and we understand this may need further input from ASF Legal and the rest of the community. Please let us know what we can do to help move this forward. We sincerely appreciate everyone's support as we navigate these licensing requirements. **Link to proposed license:** [license.txt](https://github.com/apache/arrow/files/13955180/license.txt) Best, Sarah and Kevin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
