av8or1 opened a new pull request, #39648:
URL: https://github.com/apache/arrow/pull/39648
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's
Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing
Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor
PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue for this pull request on GitHub?
https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the
[Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.)
of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
<!--
Completed the modifications to implement the DeleteFile() method to support
deletion of files on ADLS.
-->
### What changes are included in this PR?
<!--
Modified:
~cpp/src/arrow/filesystem/azurerefs.cc
~cpp/src/arrow/filesystem/azurerefs_test.cc
These modifications implement the method and provide regression testing,
respectively.
-->
### Are these changes tested?
<!--
I tested the modification by creating a file via the web browser on our
internal ADLS, then ran a sample program that deleted the file. I added three
regression tests to cover the use case scenarios of:
1) A valid delete attempt, where "valid" means that the file exists and is
indeed a file
2) An intentional failure where a file delete is attempted, but the file
does not exist
3) An intentional failure where a file delete is attempted, but the target
is not a file
-->
### Are there any user-facing changes?
<!--
This is my first contribution to the Arrow library. Therefore I am not
certain if the addition of a relatively low-level feature such as this would
propagate to external documentation. That said, given the target audience of
the library (developers), I would imagine that such a method would have
documentation.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line
below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix
either (a) a security vulnerability, (b) a bug that caused incorrect or invalid
data to be produced, or (c) a bug that causes a crash (even when the API
contract is upheld). We use this to highlight fixes to issues that may affect
users without their knowledge. For this reason, fixing bugs that cause errors
don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
