alamb commented on code in PR #8878:
URL: https://github.com/apache/arrow-datafusion/pull/8878#discussion_r1456452737
##########
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##########
@@ -1438,9 +1436,31 @@ mod tests {
let input_types = vec![DataType::Int32, DataType::Int32];
let return_type = Arc::new(DataType::Int32);
- let fun = |args: &[ArrayRef]| {
- let arg0 = as_int32_array(&args[0])?;
- let arg1 = as_int32_array(&args[1])?;
+ let fun = Arc::new(|args: &[ColumnarValue]| {
+ let len = args
Review Comment:
Maybe as a follow on PR we can make a function that does this length
inference and conversion to array (mostly so it can be documented) to make the
ideas easier to find 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
