corwinjoy commented on code in PR #39677:
URL: https://github.com/apache/arrow/pull/39677#discussion_r1456621173
##########
cpp/src/parquet/page_index.cc:
##########
@@ -908,13 +1006,13 @@ std::unique_ptr<ColumnIndex> ColumnIndex::Make(const
ColumnDescriptor& descr,
}
std::unique_ptr<OffsetIndex> OffsetIndex::Make(const void* serialized_index,
- uint32_t index_len,
+ uint32_t *index_len,
const ReaderProperties&
properties,
Decryptor* decryptor) {
format::OffsetIndex offset_index;
ThriftDeserializer deserializer(properties);
deserializer.DeserializeMessage(reinterpret_cast<const
uint8_t*>(serialized_index),
- &index_len, &offset_index, decryptor);
+ index_len, &offset_index, decryptor);
return std::make_unique<OffsetIndexImpl>(offset_index);
}
Review Comment:
I probably don't need this anymore. Originally I had to keep track of the
bytes used as I moved through the buffer. But then, I added an improved method
to the deserializer itself for speed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
