gruuya commented on code in PR #8566:
URL: https://github.com/apache/arrow-datafusion/pull/8566#discussion_r1457266257
##########
datafusion/common/src/functional_dependencies.rs:
##########
@@ -97,8 +108,38 @@ impl Constraints {
Constraint::Unique(indices)
})
}
- TableConstraint::ForeignKey { .. } => {
- _plan_err!("Foreign key constraints are not currently
supported")
+ TableConstraint::ForeignKey {
+ foreign_table,
+ columns,
+ name: _,
+ on_delete: _,
+ on_update: _,
+ referred_columns,
+ } => {
+ let column_indices = columns
+ .iter()
+ .map(|pk| {
+ let idx = df_schema
+ .fields()
+ .iter()
+ .position(|item| item.name() == &pk.value)
+ .ok_or_else(|| {
+ DataFusionError::Plan(
+ "Column doesn't exist".to_string(),
+ )
+ })?;
+ Ok(idx)
+ })
Review Comment:
Could simplify to
```rust
.map(|pk| df_schema.index_of_column_by_name(None, pk.value))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
