matthewgapp commented on code in PR #8839:
URL: https://github.com/apache/arrow-datafusion/pull/8839#discussion_r1457929401
##########
datafusion/sql/src/planner.rs:
##########
@@ -61,6 +61,15 @@ pub trait ContextProvider {
not_impl_err!("Table Functions are not supported")
}
+ /// TODO: add doc
+ fn create_cte_work_table(
Review Comment:
I'm not sure of a way to directly implement this method on the `SqlToRel`
because the `sql` code needs access to a table that contains `execution`
related types that can't be a direct dependency of the `sql` crate (namely, the
CteWorktable (see
https://github.com/matthewgapp/arrow-datafusion/blob/68c9fe7ddc0f1c5bbc1d011c6d4d34c8d73ca656/datafusion/core/src/datasource/cte_worktable.rs#L38).
The context provider was a workaround to hide the execution types behind the
context provider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
