alamb commented on code in PR #8344:
URL: https://github.com/apache/arrow-datafusion/pull/8344#discussion_r1457948336
##########
datafusion/sqllogictest/test_files/arrow_typeof.slt:
##########
@@ -384,4 +384,35 @@ LargeList(Field { name: "item", data_type: Int64,
nullable: true, dict_id: 0, di
query T
select arrow_typeof(arrow_cast(make_array([1, 2, 3]),
'LargeList(LargeList(Int64))'));
----
-LargeList(Field { name: "item", data_type: LargeList(Field { name: "item",
data_type: Int64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata:
{} }), nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} })
\ No newline at end of file
+LargeList(Field { name: "item", data_type: LargeList(Field { name: "item",
data_type: Int64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata:
{} }), nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} })
+
+## FixedSizeList
+
+query ?
+select arrow_cast(null, 'FixedSizeList(1, Int64)');
+----
+NULL
+
+#TODO: arrow-rs doesn't support it yet
Review Comment:
Shouldn't we be casting `[1]` (not `1`)?
##########
datafusion/common/src/hash_utils.rs:
##########
@@ -267,6 +268,38 @@ where
Ok(())
}
+fn hash_fixed_list_array(
Review Comment:
I didn't see any test coverage for this new code -- e.g. either unit tests
for hashing or a higher level test like `GROUP BY <FixedListArray>`
Can you either ensure this code is tested somehow, or else perhaps move the
hash support to a different PR so we can merge the `arrow_cast` support ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
