benibus commented on code in PR #39506:
URL: https://github.com/apache/arrow/pull/39506#discussion_r1458045183
##########
cpp/src/arrow/record_batch_test.cc:
##########
@@ -314,6 +314,31 @@ TEST_F(TestRecordBatch, RemoveColumn) {
AssertBatchesEqual(*new_batch, *batch4);
}
+TEST_F(TestRecordBatch, RenameColumns) {
+ const int length = 10;
+
+ auto field1 = field("f1", int32());
+ auto field2 = field("f2", uint8());
+ auto field3 = field("f3", int16());
+
+ auto schema1 = ::arrow::schema({field1, field2, field3});
+
+ random::RandomArrayGenerator gen(42);
+
+ auto array1 = gen.ArrayOf(int32(), length);
+ auto array2 = gen.ArrayOf(uint8(), length);
+ auto array3 = gen.ArrayOf(int16(), length);
+
+ auto batch = RecordBatch::Make(schema1, length, {array1, array2, array3});
+ EXPECT_THAT(batch->ColumnNames(), testing::ElementsAre("f1", "f2", "f3"));
+
+ ASSERT_OK_AND_ASSIGN(auto renamed, batch->RenameColumns({"zero", "one",
"two"}));
+ EXPECT_THAT(renamed->ColumnNames(), testing::ElementsAre("zero", "one",
"two"));
+ ASSERT_OK(renamed->ValidateFull());
Review Comment:
It wouldn't hurt to check that the renamed batch is otherwise equal to the
original.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
