jayzhan211 commented on code in PR #7893:
URL: https://github.com/apache/arrow-datafusion/pull/7893#discussion_r1459025527
##########
datafusion/physical-expr/src/aggregate/array_agg_ordered.rs:
##########
@@ -323,20 +335,32 @@ impl Accumulator for OrderSensitiveArrayAggAccumulator {
impl OrderSensitiveArrayAggAccumulator {
fn evaluate_orderings(&self) -> Result<ScalarValue> {
Review Comment:
@mustafasrepo Have you considered changing `values: Vec<ScalarValue>` and
`ordering_values: Vec<Vec<ScalarValue>>,` from vec to vecdeque for
OrderSensitiveArrayAggAccumulator too? If we can have VecDequeue here, we can
avoid `into()` and reuse evalute_orderings() for both Ordersensitive And
NthValue. They do the similar things instead one is Vec<T>, another is
VecDeque<T>.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
