alamb commented on PR #8720: URL: https://github.com/apache/arrow-datafusion/pull/8720#issuecomment-1901112256
Here is the result of the benchmarks when I ran them. My conclusion is that there is no measurable difference in performance due to this branch so it should be good to go ``` -------------------- Benchmark tpch.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main_base ┃ collect_fix ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 1 │ 327.85ms │ 328.00ms │ no change │ │ QQuery 2 │ 93.09ms │ 94.13ms │ no change │ │ QQuery 3 │ 172.44ms │ 168.23ms │ no change │ │ QQuery 4 │ 102.36ms │ 98.83ms │ no change │ │ QQuery 5 │ 199.92ms │ 210.24ms │ 1.05x slower │ │ QQuery 6 │ 95.04ms │ 97.14ms │ no change │ │ QQuery 7 │ 269.17ms │ 282.54ms │ no change │ │ QQuery 8 │ 241.80ms │ 225.48ms │ +1.07x faster │ │ QQuery 9 │ 357.00ms │ 286.67ms │ +1.25x faster │ │ QQuery 10 │ 324.27ms │ 278.82ms │ +1.16x faster │ │ QQuery 11 │ 76.61ms │ 79.25ms │ no change │ │ QQuery 12 │ 155.77ms │ 161.19ms │ no change │ │ QQuery 13 │ 325.53ms │ 346.48ms │ 1.06x slower │ │ QQuery 14 │ 127.94ms │ 126.09ms │ no change │ │ QQuery 15 │ 151.43ms │ 167.27ms │ 1.10x slower │ │ QQuery 16 │ 103.59ms │ 104.93ms │ no change │ │ QQuery 17 │ 291.58ms │ 306.44ms │ 1.05x slower │ │ QQuery 18 │ 469.92ms │ 394.92ms │ +1.19x faster │ │ QQuery 19 │ 201.67ms │ 205.44ms │ no change │ │ QQuery 20 │ 161.96ms │ 159.41ms │ no change │ │ QQuery 21 │ 323.94ms │ 330.82ms │ no change │ │ QQuery 22 │ 80.45ms │ 82.82ms │ no change │ └──────────────┴───────────┴─────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩ │ Total Time (main_base) │ 4653.33ms │ │ Total Time (collect_fix) │ 4535.15ms │ │ Average Time (main_base) │ 211.51ms │ │ Average Time (collect_fix) │ 206.14ms │ │ Queries Faster │ 4 │ │ Queries Slower │ 4 │ │ Queries with No Change │ 14 │ └────────────────────────────┴───────────┘ -------------------- Benchmark tpch.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main_base ┃ collect_fix ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 1 │ 327.85ms │ 328.00ms │ no change │ │ QQuery 2 │ 93.09ms │ 94.13ms │ no change │ │ QQuery 3 │ 172.44ms │ 168.23ms │ no change │ │ QQuery 4 │ 102.36ms │ 98.83ms │ no change │ │ QQuery 5 │ 199.92ms │ 210.24ms │ 1.05x slower │ │ QQuery 6 │ 95.04ms │ 97.14ms │ no change │ │ QQuery 7 │ 269.17ms │ 282.54ms │ no change │ │ QQuery 8 │ 241.80ms │ 225.48ms │ +1.07x faster │ │ QQuery 9 │ 357.00ms │ 286.67ms │ +1.25x faster │ │ QQuery 10 │ 324.27ms │ 278.82ms │ +1.16x faster │ │ QQuery 11 │ 76.61ms │ 79.25ms │ no change │ │ QQuery 12 │ 155.77ms │ 161.19ms │ no change │ │ QQuery 13 │ 325.53ms │ 346.48ms │ 1.06x slower │ │ QQuery 14 │ 127.94ms │ 126.09ms │ no change │ │ QQuery 15 │ 151.43ms │ 167.27ms │ 1.10x slower │ │ QQuery 16 │ 103.59ms │ 104.93ms │ no change │ │ QQuery 17 │ 291.58ms │ 306.44ms │ 1.05x slower │ │ QQuery 18 │ 469.92ms │ 394.92ms │ +1.19x faster │ │ QQuery 19 │ 201.67ms │ 205.44ms │ no change │ │ QQuery 20 │ 161.96ms │ 159.41ms │ no change │ │ QQuery 21 │ 323.94ms │ 330.82ms │ no change │ │ QQuery 22 │ 80.45ms │ 82.82ms │ no change │ └──────────────┴───────────┴─────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩ │ Total Time (main_base) │ 4653.33ms │ │ Total Time (collect_fix) │ 4535.15ms │ │ Average Time (main_base) │ 211.51ms │ │ Average Time (collect_fix) │ 206.14ms │ │ Queries Faster │ 4 │ │ Queries Slower │ 4 │ │ Queries with No Change │ 14 │ └────────────────────────────┴───────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
