alamb commented on code in PR #8914: URL: https://github.com/apache/arrow-datafusion/pull/8914#discussion_r1459863692
########## datafusion/sqllogictest/test_files/aggregate.slt: ########## @@ -3260,3 +3260,19 @@ query I select count(*) from (select count(*) a, count(*) b from (select 1)); ---- 1 + Review Comment: Can we also add another test where there is a single row that doesn't actually pass the predicate? Like ``` CREATE TABLE t(col0 INTEGER) as VALUES(2); SELECT MIN(col0) FROM empty WHERE col0=1; SELECT MAX(col0) FROM empty WHERE col0=1; ``` So the table is not actually empty but the filter removes it all -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
