tustvold commented on code in PR #5316:
URL: https://github.com/apache/arrow-rs/pull/5316#discussion_r1460365403


##########
object_store/src/parse.rs:
##########
@@ -305,4 +306,28 @@ mod tests {
         let (_, path) = parse_url(&url).unwrap();
         assert_eq!(path.as_ref(), "my file with spaces");
     }
+
+    #[tokio::test]
+    #[cfg(feature = "http")]
+    async fn test_url_http() {
+        use crate::client::mock_server::MockServer;
+        use hyper::{header::USER_AGENT, Body, Response};
+
+        let server = MockServer::new();
+
+        server.push_fn(|r| {
+            assert_eq!(r.uri().path(), "/foo/bar");
+            assert_eq!(r.headers().get(USER_AGENT).unwrap(), "test_url");
+            Response::new(Body::empty())
+        });
+
+        let test = format!("{}/foo/bar", server.url());

Review Comment:
   I will roll this into https://github.com/apache/arrow-rs/issues/5274



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to