felipecrv opened a new pull request, #39719:
URL: https://github.com/apache/arrow/pull/39719
### Rationale for this change
Only the "*IfExists" functions from the Azure SDK ever set
`response.Value.Deleted` to `false` to indicate that a resource wasn't found
and the request succeeded without deleting anything.
It's better that we use the `Delete()` versions of these functions instead
of `DeleteIfExists` and check the `ErrorCode` ourselves to return an
appropriate `Status` instead of something generic.
### What changes are included in this PR?
- Removing `StatusFromErrorResponse`
- Comments explaining the error handling decisions
- Addition of a boolean parameter to `DeleteDirOnFileSystem` that controls
how it fails when the directory being deleted doesn't exist
### Are these changes tested?
- Yes, by the existing tests in `azurefs_test.cc`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
