alamb commented on PR #8849: URL: https://github.com/apache/arrow-datafusion/pull/8849#issuecomment-1902436699
I tested the effect of the short string optimization here For the queries that actually have short strings (Q2, Q3), it seems to add 5% performance, and thus I am inclined to keep it. I also think the current PR's code is only minimally more complicated ## With the short string optimization (this PR): ```shell andrewlamb@Andrews-MacBook-Pro:~/Downloads$ ./datafusion-cli-distinct-strings -f strings.sql | grep 'Query took' 1 row in set. Query took 0.910 seconds. 1 row in set. Query took 0.366 seconds. 10 rows in set. Query took 0.684 seconds. ``` ## without the short string optimizaton ```shell ./datafusion-cli-distinct-strings-no-small -f strings.sql | grep 'Query took' 1 row in set. Query took 0.902 seconds. 1 row in set. Query took 0.384 seconds. 10 rows in set. Query took 0.691 seconds. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
