Ted-Jiang commented on code in PR #8930:
URL: https://github.com/apache/arrow-datafusion/pull/8930#discussion_r1460763662
##########
datafusion/core/src/datasource/physical_plan/parquet/row_groups.rs:
##########
@@ -169,8 +174,8 @@ pub(crate) async fn prune_row_groups_by_bloom_filters<
/// Implements `PruningStatistics` for Parquet Split Block Bloom Filters (SBBF)
struct BloomFilterStatistics {
- /// Maps column name to the parquet bloom filter
- column_sbbf: HashMap<String, Sbbf>,
+ /// Maps column name to the parquet bloom filter and parquet physical type
+ column_sbbf: HashMap<String, (Sbbf, Type)>,
Review Comment:
because the sbbf `check` input is parquet type, so we need know the read
`parquet physical type` when construct check value 🤔 , is there any another way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
