alamb commented on PR #8923:
URL: 
https://github.com/apache/arrow-datafusion/pull/8923#issuecomment-1902642792

   > Are there any additional tests which we should add to improve coverage for 
the parallel writer?
   
   I think if we could including tests that write lists of structs and structs 
of lists that would also be good 
   
   Perhaps like
   ```sql
   
   ❯ select [struct('foo', 1), struct('bar', 2)];
   +-----------------------------------------------------------------------+
   | make_array(struct(Utf8("foo"),Int64(1)),struct(Utf8("bar"),Int64(2))) |
   +-----------------------------------------------------------------------+
   | [{c0: foo, c1: 1}, {c0: bar, c1: 2}]                                  |
   +-----------------------------------------------------------------------+
   1 row in set. Query took 0.002 seconds.
   ```
   
   ```sql
   ❯ select struct('foo', [1,2,3], struct('bar', [2,3,4]));
   
+-----------------------------------------------------------------------------------------------------------------------+
   | 
struct(Utf8("foo"),make_array(Int64(1),Int64(2),Int64(3)),struct(Utf8("bar"),make_array(Int64(2),Int64(3),Int64(4))))
 |
   
+-----------------------------------------------------------------------------------------------------------------------+
   | {c0: foo, c1: [1, 2, 3], c2: {c0: bar, c1: [2, 3, 4]}}                     
                                           |
   
+-----------------------------------------------------------------------------------------------------------------------+
   1 row in set. Query took 0.003 seconds.
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to