haohuaijin commented on issue #8910: URL: https://github.com/apache/arrow-datafusion/issues/8910#issuecomment-1903835815
Thank you @jackwener. I am interested in it. I have two solutions. ## First We can first fold the expression whenever, and if we encounter an error, return the origin expression in the below code and the error will occur in runtime if it is a real error(not the short-circuit problem). https://github.com/apache/arrow-datafusion/blob/2b218be67a6c412629530b812836a6cec76efc32/datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs#L282-L287 ## Second don't simplify short-circuit expressions's all sub-expressions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
