pitrou commented on code in PR #39681:
URL: https://github.com/apache/arrow/pull/39681#discussion_r1462038653
##########
java/memory/memory-core/src/main/java/org/apache/arrow/memory/ArrowBuf.java:
##########
@@ -346,6 +347,29 @@ public void setLong(long index, long value) {
MemoryUtil.UNSAFE.putLong(addr(index), value);
}
+ /**
+ * Get float16 value stored at a particular index in the
+ * underlying memory chunk this ArrowBuf has access to.
+ * @param index index (0 based relative to this ArrowBuf)
+ * where the value will be read from
+ * @return 4 byte float value
+ */
+ public short getFloat16(long index) {
Review Comment:
Given that `setFloat16` takes a float, by symmetry this method should
probably return a float too.
@danepitkin WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
