lidavidm commented on code in PR #1475:
URL: https://github.com/apache/arrow-adbc/pull/1475#discussion_r1462112052
##########
java/core/src/main/java/org/apache/arrow/adbc/core/AdbcDriver.java:
##########
@@ -60,7 +61,8 @@ public interface AdbcDriver {
/**
* Open a database via this driver.
*
+ * @param allocator The allocator to use to back the AdbcDatabase.
* @param parameters Driver-specific parameters.
*/
- AdbcDatabase open(Map<String, Object> parameters) throws AdbcException;
+ AdbcDatabase open(BufferAllocator allocator, Map<String, Object> parameters)
throws AdbcException;
Review Comment:
I'm mostly worried about the breaking change here.
Would it perhaps be possible to register a driver _factory_ via
ServiceProvider? That could be instantiated with no arguments and would have a
`getDriver(BufferAllocator)` or similar?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
