lukedg97 opened a new pull request, #39751:
URL: https://github.com/apache/arrow/pull/39751
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's
Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing
Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor
PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue for this pull request on GitHub?
https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the
[Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.)
of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
Fixes my own issue: https://github.com/apache/arrow/issues/39709
### What changes are included in this PR?
Fixes two lines of code which initialize ChunkedArrays for Date32 and Date64
as ArrowString instead. This does not prevent creation of Arrow objects,
instead failing when trying to use the column data as in:
```
switch column.type.info {
...
case ArrowType.Info.variableInfo(ArrowTypeId.date32):
let data = column.data() as ChunkedArray<Foundation.Date>
return data.asString
case ArrowType.Info.primitiveInfo(ArrowTypeId.date64):
let data = column.data() as ChunkedArray<Foundation.Date>
return data.asString
```
This ultimately occurs because the column.type.info and ChunkedArray data
types will not match. Fixing the ChunkedArray initialization fixes this error.
### Are these changes tested?
I have tested these changes in my project. However I see that you have
automated tests and will work to add some to cover this. Any guidance or help
here is appreciated.
### Are there any user-facing changes?
I don't believe this has user-facing changes beyond fixing to expected
behavior.
<!--
Please uncomment the line below (and provide explanation) if the changes fix
either (a) a security vulnerability, (b) a bug that caused incorrect or invalid
data to be produced, or (c) a bug that causes a crash (even when the API
contract is upheld). We use this to highlight fixes to issues that may affect
users without their knowledge. For this reason, fixing bugs that cause errors
don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
