mustafasrepo commented on PR #8955: URL: https://github.com/apache/arrow-datafusion/pull/8955#issuecomment-1905388353
I think we should continue with the [PR](https://github.com/apache/arrow-datafusion/pull/8945). The reason is that: - In this implementation while creating window expr, we use `window schema` fields to get data type. However, conceptually it should only use its input fields (argument name also suggests that). - secondly in this implementation `create_window_expr_with_name` function has a conversion from `DfSchema` to `Schema`. This depends on their field names to be same, however this is not always the same -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
