mustafasrepo commented on code in PR #8920:
URL: https://github.com/apache/arrow-datafusion/pull/8920#discussion_r1462795965
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -1572,7 +1575,8 @@ pub fn create_window_expr_with_name(
create_physical_sort_expr(e, logical_input_schema,
execution_props)
Review Comment:
> > Hmm, this looks incorrect as you use window's schema as input schema.
Although window's schema is input schema + window functions output, it is why
this change still makes thing work. But it is actually misleading for readers
and probably cause of potential bugs.
>
> This may be what @mustafasrepo has improved in [#8920
(comment)](https://github.com/apache/arrow-datafusion/pull/8920#issuecomment-1903509981)
Exactly, I re-introduced the invariant of using only input schema
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
