manoj-inukolunu commented on code in PR #8848:
URL: https://github.com/apache/arrow-datafusion/pull/8848#discussion_r1463848262
##########
datafusion/core/src/datasource/physical_plan/parquet/page_filter.rs:
##########
@@ -249,10 +260,7 @@ impl PagePruningPredicate {
/// that `extract_page_index_push_down_predicates` only return
/// predicate with one col)
///
-fn find_column_index(
- predicate: &PruningPredicate,
- row_group_metadata: &RowGroupMetaData,
-) -> Option<usize> {
+fn find_column_name(predicate: &PruningPredicate) -> Option<String> {
Review Comment:
Thank you @alamb I like the proposal its much cleaner. I have merged your
pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
