alamb commented on issue #8965: URL: https://github.com/apache/arrow-datafusion/issues/8965#issuecomment-1906832546
Ideally, something early in the code (perhaps the type coercion logic) should return an error if the argument to `not` can't be coerced to Boolean It looks like perhaps we need to add a clause to https://github.com/apache/arrow-datafusion/blob/af3d19038ef40e45c70c6e9a28798ee53795dfe9/datafusion/optimizer/src/analyzer/type_coercion.rs#L179-L182 Perhaps following the model of `Expr::IsNotNull` As @haohuaijin notes we may want to update https://github.com/apache/arrow-datafusion/blob/e642cc2a94f38518d765d25c8113523aedc29198/datafusion/physical-expr/src/expressions/not.rs#L83-L92 to not check for `is_null` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
