jduo opened a new pull request, #1487: URL: https://github.com/apache/arrow-adbc/pull/1487
From (#572 ): - Removed unused FlightClient from `FlightSqlDatabase` - FlightClient creation moved from `FlightSqlDatabase` to `FlightSqlConnection`. In the existing version after connect() is called a new client object is created, but all of them shared the same allocator. That was probably a bug, right? - username/password passed as parameters named `adbc.username` and `adbc.password` (to be added in `AdbcDriver`). Are there any plans to have some sort of connection string syntax like JDBC? - As there can be more than one FlightClients, I wanted to avoid keeping track of auth token, so added a middleware that does both: extract an auth token and pass it on future calls. It's functionally similar to the go example, but I couldn't use `authenticateBasicToken` because I couldn't find a way to extract bearer value from CredenialCallOption. Maybe there's a simpler way to accomplish this??? - I'd like to keep FlightClient creation logic contained in `clientCache`. Right now the main FlightClient is created independently and only Endpoint clients are obtained from cache. If changed, main client will always have to be obtained from cache before usage, otherwise it might have expired. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
