nbruno commented on a change in pull request #9151:
URL: https://github.com/apache/arrow/pull/9151#discussion_r565618713



##########
File path: java/vector/src/main/codegen/templates/UnionWriter.java
##########
@@ -110,6 +143,26 @@ public ListWriter asList() {
     return getListWriter();
   }
 
+  private MapWriter getMapWriter() {
+    // returns existing writer
+    Preconditions.checkNotNull(mapWriter);

Review comment:
       I think this is another case of, we need keysSorted in order to create 
the writer so we can't construct a new writer, but must rely on an existing one.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to