kallisti-dev opened a new pull request, #8977: URL: https://github.com/apache/arrow-datafusion/pull/8977
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Closes #8976. ## Rationale for this change It should be possible for the types of parameter values and placeholders to be different, as long as the `ScalarValue` is coercible to the `Expr::Placeholder`s data type. ## What changes are included in this PR? Removal of the eager `==` check on data types, which allows type coercion to happen later in planning. ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? The `data_type` argument to `ParamValues::getplaceholders_with_values` is currently unused. If we decide to remove it that would be a user-facing change to the API. Alternatively, instead of deleting the eager check, we could improve the eager check with code borrowed from `datafusion_expr::type_coercion::functions::can_coerce_from`, but I'm not sure of the best way to bridge the dependency gap there (`datafusion_common` doesn't currently depend on `datafusion_expr`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
